Cleanup cmake rules #566
Cleanup cmake rules #566
Conversation
|
Fixes #73 |
|
Did you try a clean build? |
|
I just cloned your repo and confirmed that it works as expected... don't know what is going on here ... I'm for applying it ... @nickoe ? |
|
to @nickoe: are we sure that Travis do correctly clean up before building? |
|
Yes, I am pretty sure. that it the intention. Are you building the same way as travis?
|
|
Yes definitely |
|
May I go ahead and merge? |
|
I also use the same command sequence to build |
|
Just had an idea whats going wrong here - I only build html and pdf, but not epub. a) add a dependency to force serialization |
|
Ok try commit and lets see what it happens ... BTW the above command build all docs in parallel and I didn't see any problem at all... |
|
Can you just wait a little bit - I have fixed it locally and just need to cleanup |
…ilds As stated in the add_custom_target documentation, the target "is always considered out of date". Instead, only add the output file as a target dependency and create the file using add_custom_command. With this change the documentation is only recreated when the input changes. Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Instead of creating custom target for each intermediate output, like translated asciidocs, just add/append the generated output files as a dependency. Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
StefanBruens
force-pushed
the
cleanup_cmake_rules
branch
from
69beacd to
1a7bc75
Compare
|
Great! Thanks @StefanBruens! |
|
Now the build time went from 2 hr 9 min to about 43 min. Thanks. |
|
@StefanBruens Will you be able to throw some tips on KiCad/kicad-i18n#208 ? |
Currently, the whole documentation gets build twice when doing "make && make install", as all files are created using commands specified in "add_custom_target".
As documented for add_custom_target, these commands are always executed. The correct way to only rebuild on changes is a combination of
add_custom_target(target DEPENDS file)andadd_custom_command(OUTPUT file COMMANDS ...).